use Plotly axis titles if not facetted #573
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #510, axis titles can be positioned improperly depending on the size of the plot. In a2aedac, axis titles were changed to annotations, so they are not duplicated and work much more similarly to
ggplot2
. Unfortunately,plotly
annotations are positioned based on a[0,1]
scale with respect to the plot area. This means the axis titles scale inversely and negatively to the plot size. When the plot is small, thex
axis title will be placed too high. When the plot is large/high, thex
axis title moves too far down sometimes out of the svg bounding box.This pull changes to use
plotly
axis titles when the plot is not facetted. When the plot is facetted, theplotly
axis titles are changed to""
in favor of the annotation approach.